[Builtins] Make 'BuiltinFailure' the last constructor #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '191103257' (base) and 'b1ee0ff59' (PR) Results table
|
|
/benchmark nofib |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '191103257' (base) and 'b1ee0ff59' (PR) Results table
|
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark validation |
|
@aadaa-fgtaa is telling me that simply making the constructor first isn't anywhere near being a reliable way to force GHC to branch-predict it and that for e.g. data Foo = Bar | Baz
f Bar = 1#
f Baz = 2#GHC would branch-predict the second one. Making the @aadaa-fgtaa also referenced this GHC ticket. We don't lose anything by reordering the constructors though, so if it helps some benchmarks, let's just do it and pray that GHC doesn't break things. |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '191103257' (base) and 'b1ee0ff59' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '191103257' (base) and 'b1ee0ff59' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '191103257' (base) and 'b1ee0ff59' (PR) Results table
|
|
/benchmark nofib |
4 similar comments
|
/benchmark nofib |
|
/benchmark nofib |
|
/benchmark nofib |
|
/benchmark nofib |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark lists |
1 similar comment
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
…to effectfully/builtins/make-BuiltinFailure-the-last-constructor
|
/benchmark validation |
|
/benchmark nofib |
|
/benchmark lists |
|
/benchmark validation |
|
/benchmark nofib |
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '7b3fd3e41' (base) and 'd294c0e55' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '7b3fd3e41' (base) and 'd294c0e55' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '7b3fd3e41' (base) and 'd294c0e55' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '7b3fd3e41' (base) and 'd294c0e55' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '7b3fd3e41' (base) and 'd294c0e55' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '7b3fd3e41' (base) and 'd294c0e55' (PR) Results table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying out.