Use Int64 in CostModelParams #5920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwxm
reviewed
Apr 25, 2024
There was a problem hiding this comment.
This is a great improvement. I was confused for a little while because we use Int64 in the cost model parameters but the actual cost model ultimately contains SatInts disguised as CostingInts and I couldn't see a conversion anywhere, but now I think that's secretly happening in the horrible applyParameters code where everything gets converted to JSON and back and all of our integral types get converted to/from Scientific. We really should get rid of the Aeson translation and make it explicit what's going on.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this thread.