[PIR] Don't generate 'fixBy' if you don't need to #5954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
enhancement
Plutus IR
No Changelog Required
Unisay
requested changes
May 6, 2024
…to effectfully/plutus-ir/do-not-generate-fixBy-if-you-do-not-need-to
Well, I can't do that in this PR, because this PR removes generation of |
Unisay
approved these changes
May 6, 2024
…to effectfully/plutus-ir/do-not-generate-fixBy-if-you-do-not-need-to
effectfully
commented
May 6, 2024
| @@ -79,6 +79,51 @@ applyFun = runQuote $ do | |||
| . lamAbs () x (TyVar () a) | |||
| $ apply () (var () f) (var () x) | |||
|
|
|||
| {- Note [Recursion combinators] | |||
There was a problem hiding this comment.
Oops, I confused branches and added the Note in this one rather than the strictify-fix one. Doesn't matter much, I guess.
Comment on lines
-6
to
-16
| fixBy | ||
| (all | ||
| F | ||
| (fun (type) (type)) | ||
| (fun | ||
| (fun (all Q (type) (fun [ F Q ] Q)) (all Q (type) (fun [ F Q ] Q))) | ||
| (fun | ||
| (all Q (type) (fun [ F Q ] [ F Q ])) (all Q (type) (fun [ F Q ] Q)) | ||
| ) | ||
| ) | ||
| ) |
effectfully
deleted the
effectfully/plutus-ir/do-not-generate-fixBy-if-you-do-not-need-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate
fixBy(a combinator used for compiling mutual recursion) whenever we have any recursive functions in the PIR program, but most of those only need the basic Z combinator and no fancyfixBystuff, so generating the latter is pointless and can be very confusing if you want to look at the output of the compiler without optimizations (in particular, DCE) turned on. Not generatingfixByif you don't need to is trivial, so let's do that.