Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove the doctests runner of 'prettyprinter-configurable' #5974

Conversation

effectfully
Copy link
Contributor

The doctests runner of prettyprinter-configurable has been broken for years, so this PR removes it. If we want to run the doctests, we should use cabal-docspec anyway and the existing code doesn't help with it, so we can drop it as well.

@effectfully effectfully requested a review from zliu41 May 14, 2024 04:17
@effectfully effectfully self-assigned this May 14, 2024
@effectfully effectfully added the No Changelog Required Add this to skip the Changelog Check label May 14, 2024
Copy link
Contributor

@Unisay Unisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, unused code is a liability.

@effectfully effectfully merged commit 59d4b04 into master May 14, 2024
7 of 9 checks passed
@effectfully effectfully deleted the effectfully/build/remove-prettyprinter-configurable-doctests branch May 14, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants