Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabal project to compile docusaurus examples. #6239

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Jun 25, 2024

Before this PR:

  • docusaurus project contains Haskell source files that aren't typechecked and might contain compilation errors.
  • A change in the Plutus plug-in or API might break examples without any CI failure.
  • CIP-57 Example validator script isn't compatible with the CIP-69 and CIP-117.

After this PR:

  • Cabal package docusaurus-examples exists to build a single executable example-cip57 (for now) which compiles a corresponding CIP-57 Blueprint example.
  • A change in the Plutus plug-in or API that breaks examples will cause the whole project build to fail CI.
  • CIP-57 Example validator script is compatible with the CIP-69 and CIP-117.

@Unisay Unisay self-assigned this Jun 25, 2024
@Unisay Unisay added Internal No Changelog Required Add this to skip the Changelog Check status: triaged labels Jun 25, 2024
@Unisay Unisay force-pushed the yura/docusaurus-examples-cabal-project branch from 6d65684 to 93c3fcb Compare June 25, 2024 12:37
@Unisay Unisay requested a review from zeme-wana June 25, 2024 13:16
@Unisay Unisay force-pushed the yura/docusaurus-examples-cabal-project branch 2 times, most recently from 1ca12a9 to f7ebc85 Compare June 26, 2024 09:38
@Unisay Unisay force-pushed the yura/docusaurus-examples-cabal-project branch from f7ebc85 to 6221981 Compare June 26, 2024 10:05
@Unisay Unisay merged commit 89a8aa1 into master Jun 26, 2024
6 checks passed
@Unisay Unisay deleted the yura/docusaurus-examples-cabal-project branch June 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal No Changelog Required Add this to skip the Changelog Check status: triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants