Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mm/refactoring/comments2 #4

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Mm/refactoring/comments2 #4

merged 9 commits into from
Oct 9, 2023

Conversation

matthieu4294967296moineau
Copy link

Refactoring

  • removed package gorilla/websocket from lint file
  • added link to doc
  • possible to define other websocket protocol via header
  • removed buffer from channels
  • checking context
  • possibility to have several subscriptions on the same webSocket connection
  • only one go routine is running (to listen for the webSocket messages)

@matthieu4294967296moineau matthieu4294967296moineau deleted the mm/refactoring/comments2 branch October 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@matthieu4294967296moineau