Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Middleware example to docs #14

Merged
merged 3 commits into from
Apr 4, 2022
Merged

feat: Middleware example to docs #14

merged 3 commits into from
Apr 4, 2022

Conversation

casualmatt
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

New section with an example on how to use a middleware for auth redirect
#8

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

New section with an example on how to use a middleware for auth redirect
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for nuxt-directus ready!

Name Link
🔨 Latest commit 67caccb
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-directus/deploys/624ae2498654a300095f4f6f
😎 Deploy Preview https://deploy-preview-14--nuxt-directus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Intevel
Copy link
Owner

Intevel commented Apr 4, 2022

Thanks for this PR 💚
But please call it "Middleware example", so the docs section

Rename title for the new section with "Middleware example"
@casualmatt
Copy link
Collaborator Author

Fix 👍

Copy link
Owner

@Intevel Intevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this changes, I will approve. Thanks for your work 💚

docs/content/en/usage/useDirectusAuth.md Outdated Show resolved Hide resolved
docs/content/en/usage/useDirectusAuth.md Outdated Show resolved Hide resolved
@Intevel
Copy link
Owner

Intevel commented Apr 4, 2022

And you have to take a look at this: https://www.conventionalcommits.org/en/v1.0.0/
Fix your PR and commit messages, I cant merge it until you did.

@Intevel Intevel changed the title Add"Redirect user to login" feat: Middleware example to docs Apr 4, 2022
@Intevel
Copy link
Owner

Intevel commented Apr 4, 2022

Fixed it, merged! Thanks for your work

@Intevel Intevel merged commit 97312c5 into Intevel:main Apr 4, 2022
@casualmatt
Copy link
Collaborator Author

Sorry,
lunch time, next time i will follow your suggestion, so that you don't need to spent too much time on it.
👍

@Intevel
Copy link
Owner

Intevel commented Apr 4, 2022

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants