feat!: implement rfc#136 (oauth, token refresh) #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you call login/logout with an expired token set, it will throw a 401.
Intevel
requested changes
Apr 28, 2023
|
The breaking change was "Modification to auto-fetch may change intended behaviour" I wasn't sure how the initial one worked, as it only seemed to fetch when the plugin was registered? |
casualmatt
approved these changes
May 2, 2023
Also moved the check into a composable, so it can be used elsewhere.
Intevel
approved these changes
May 13, 2023
|
Thanks for this PR, I will release this changes when we documented it and fixed other bugs. |
|
This PR is now released, but we have to document this changes. |
|
I will do it if for you is ok |
Sure, you can make an own branch and a PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Modification to auto-fetch may change intended behaviour
Description
Resolves:
#136
#131
Checklist: