Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling #150

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fix error handling #150

merged 2 commits into from
Jun 7, 2023

Conversation

Intevel
Copy link
Owner

@Intevel Intevel commented Jun 7, 2023

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #147 the error message is now available at the data key of the error object. The statusMessage is now the statusText from the response again.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@Intevel Intevel mentioned this pull request Jun 7, 2023
Closed
@Intevel Intevel merged commit a8cb6fa into main Jun 7, 2023
5 checks passed
@Intevel Intevel deleted the fix-error-handling branch August 4, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot catch login error (TypeError: statusMessage.replace is not a function)
1 participant
@Intevel