Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nuxt env naming convention for directus url #184

Merged
merged 4 commits into from
Aug 12, 2023

Conversation

Sandros94
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Didn't open an Issue for this, but basically since the changes in #127 the default value for directus.url hasn't been updated to follow the naming convention of the public runtimeConfig env variables

Quoting the docs:

Anything under public and app will be exposed to the frontend as well. Values are automatically replaced by matching env variables at runtime, e.g. setting an environment variable NUXT_API_KEY=my-api-key NUXT_PUBLIC_BASE_URL=/foo/ would overwrite the two values in the example below.
Example:

 export default {
   runtimeConfig: {
     apiKey: '' // Default to an empty string, automatically set at runtime using process.env.NUXT_API_KEY
     public: {
       baseURL: '' // Exposed to the frontend as well.
     }
   }
 }

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@Sandros94
Copy link
Collaborator Author

P.S: idk why github forced me to include the merge commits. Any ideas on how could I drop them from this PR?

@vercel
Copy link

vercel bot commented Aug 10, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Intevel on Vercel.

@Intevel first needs to authorize it.

@Intevel Intevel merged commit 945f3e3 into Intevel:main Aug 12, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants