Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scp for access token #133

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix scp for access token #133

merged 2 commits into from
May 23, 2023

Conversation

enadeau
Copy link
Contributor

@enadeau enadeau commented May 22, 2023

Fixed the bug caused by 4.1 caused by the fact that the scp field is not defined for non-user token.

Made the scp attribute on user a list of string that defaults to the empty list.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #133 (38210fc) into main (6de7704) will not change coverage.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files           6        6           
  Lines         243      248    +5     
=======================================
+ Hits          243      248    +5     
Impacted Files Coverage Δ
fastapi_azure_auth/user.py 100.0% <100.0%> (ø)

@enadeau
Copy link
Contributor Author

enadeau commented May 22, 2023

@JonasKs On my side this is ready to go. I went a different way than the one you were suggesting, I used a validator to convert the scopes into a list.

@JonasKs JonasKs merged commit f78c243 into Intility:main May 23, 2023
9 of 10 checks passed
@JonasKs
Copy link
Member

JonasKs commented May 23, 2023

Thank you 😊

@enadeau enadeau deleted the fix-scp branch July 29, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants