Skip to content

Commit

Permalink
Listen to Scott Arciszewski
Browse files Browse the repository at this point in the history
  • Loading branch information
tvlooy committed Feb 22, 2018
1 parent edd64b3 commit a4bec98
Show file tree
Hide file tree
Showing 3 changed files with 165 additions and 13 deletions.
11 changes: 6 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,19 @@
"geoip2/geoip2": "^2.6"
},
"require-dev": {
"phpunit/phpunit": "^7.0",
"behat/behat": "^3.2",
"behat/mink": "^1.7",
"behat/mink-browserkit-driver": "^1.3",
"behat/mink-extension": "^2.2",
"behat/mink-selenium2-driver": "^1.3",
"behat/symfony2-extension": "^2.1",
"se/selenium-server-standalone": "3.4.*",
"lakion/mink-debug-extension": "^1.2",
"webmozart/assert": "^1.1",
"doctrine/data-fixtures": "^1.2",
"doctrine/doctrine-fixtures-bundle": "^2.3"
"doctrine/doctrine-fixtures-bundle": "^2.3",
"lakion/mink-debug-extension": "^1.2",
"phpunit/phpunit": "^7.0",
"roave/security-advisories": "dev-master",
"se/selenium-server-standalone": "3.4.*",
"webmozart/assert": "^1.1"
},
"scripts": {
"travis-build": [
Expand Down
160 changes: 158 additions & 2 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions var/SymfonyRequirements.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,9 @@
class Requirement
{
private $fulfilled;

private $testMessage;

private $helpText;

private $helpHtml;

private $optional;

/**
Expand Down Expand Up @@ -264,7 +260,7 @@ public function addPhpIniRecommendation($cfgName, $evaluation, $approveCfgAbsenc
*
* @param RequirementCollection $collection A RequirementCollection instance
*/
public function addCollection(self $collection)
public function addCollection(RequirementCollection $collection)
{
$this->requirements = array_merge($this->requirements, $collection->all());
}
Expand Down Expand Up @@ -384,7 +380,6 @@ public function getPhpIniConfigPath()
class SymfonyRequirements extends RequirementCollection
{
const LEGACY_REQUIRED_PHP_VERSION = '5.3.3';

const REQUIRED_PHP_VERSION = '5.5.9';

/**
Expand Down

1 comment on commit a4bec98

@acrobat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Please sign in to comment.