Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to BaseBench #18

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Minor improvements to BaseBench #18

merged 2 commits into from
Apr 16, 2024

Conversation

Intuity
Copy link
Owner

@Intuity Intuity commented Apr 16, 2024

  • Fixing issue with the BaseBench.parameter decorator not respecting default values when no parameter override is provided;
  • Returning instance from BaseBench.register for convenience.

@Intuity Intuity requested a review from Kotarski April 16, 2024 07:24
Kotarski
Kotarski approved these changes Apr 16, 2024
View reviewed changes
forastero/bench.py Show resolved Hide resolved
@Intuity Intuity merged commit a7c17fc into main Apr 16, 2024
2 checks passed
@Intuity Intuity deleted the fix-test-params branch April 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kotarski Kotarski Kotarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Intuity @Kotarski