HIVE-28307: Fast return when database exists and IF NOT EXISTS clause…

… is enabled (apache#5292)(Wechar Yu, reviewed by Butao Zhang)
InvisibleProgrammer · Jun 20, 2024 · 1c9969a · 1c9969a
1 parent 5114a8e
commit 1c9969a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/create/CreateDatabaseAnalyzer.java b/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/create/CreateDatabaseAnalyzer.java
@@ -90,6 +90,10 @@ public void analyzeInternal(ASTNode root) throws SemanticException {
       }
     }
 
+    if (ifNotExists && getDatabase(databaseName, false) != null) {
+      return;
+    }
+
     CreateDatabaseDesc desc = null;
     Database database = new Database(databaseName, comment, locationUri, props);
     if (type.equalsIgnoreCase(DatabaseType.NATIVE.name())) {

diff --git a/ql/src/test/results/clientpositive/llap/database.q.out b/ql/src/test/results/clientpositive/llap/database.q.out
@@ -17,10 +17,8 @@ default
 test_db
 PREHOOK: query: CREATE DATABASE IF NOT EXISTS test_db
 PREHOOK: type: CREATEDATABASE
-PREHOOK: Output: database:test_db
 POSTHOOK: query: CREATE DATABASE IF NOT EXISTS test_db
 POSTHOOK: type: CREATEDATABASE
-POSTHOOK: Output: database:test_db
 PREHOOK: query: SHOW DATABASES
 PREHOOK: type: SHOWDATABASES
 POSTHOOK: query: SHOW DATABASES