Tech 4449 appraisal phase 1 #19
Conversation
.dependabot/config.yml
Outdated
| version_requirement_updates: "off" | ||
| commit_message: | ||
| prefix: "No-Jira" | ||
| include_scope: true |
There was a problem hiding this comment.
Missing newline here I think?
There was a problem hiding this comment.
looks like my script isn't adding the newline to the end 👎 i've gone ahead and added it
| @@ -51,3 +51,6 @@ build-iPhoneSimulator/ | |||
|
|
|||
| # rubocop | |||
| .rubocop-https---raw-githubusercontent-com-Invoca-style-guide-master-ruby--rubocop-yml | |||
|
|
|||
| # appraisal | |||
| gemfiles/*.lock | |||
There was a problem hiding this comment.
Interesting--I'd missed this subtlety. The appraisals generate a fresh Gemfile.lock each time?
There was a problem hiding this comment.
yea, this is a best practice set by the appraisals gem to make sure that the appraisal is always tested against the most recent version of the lock. it leans very heavily on semantic versioning and locking.
| @@ -0,0 +1 @@ | |||
| 2.6.5 | |||
There was a problem hiding this comment.
Is the hyphen file best practice?
There was a problem hiding this comment.
.ruby_version isn't picked up by rbenv only .ruby-version is. so the file name change was necessary for the configuration to take affect.
|
|
||
| appraise 'rails-6' do | ||
| gem 'activesupport', '~> 6.0' | ||
| end |
| gem 'rspec_junit_formatter' | ||
| end | ||
| gem 'rspec' | ||
| gem 'rspec_junit_formatter' |
There was a problem hiding this comment.
Thanks for simplifying here!
CHANGELOG.md
Outdated
| @@ -3,6 +3,18 @@ | |||
| Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [0.7.0] - Unreleased | |||
There was a problem hiding this comment.
BTW I have 0.7.0 also in a branch. We may be able to release those together.
| @logger.formatter = ->(_, _, _, msg_with_context) { "#{msg_with_context.to_json}\n" } | ||
| @logger = ActiveSupport::TaggedLogging.new(@logger) | ||
| @logger = ContextualLogger.new(@logger) |
There was a problem hiding this comment.
Yuck, I hadn't noticed how this overwrites @logger! I will fix that on my branch.
[0.7.0] - Unreleased
Added
Changed
Fixed
delegatebug in ActiveSupport version 4