Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech 4608 remove unnecessary timestamps #31

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Tech 4608 remove unnecessary timestamps #31

merged 5 commits into from
Aug 17, 2020

Conversation

jebentier
Copy link
Collaborator

[0.9.0] - Unreleased

Removed

  • Removed unnecessary duplicate context (severity, timestamp, and progname) in message hash passed to formatter. These are already passed to the formatter as arguments so that the formatter and decided how to add them to the log line.

@jebentier jebentier self-assigned this Aug 17, 2020
ColinDKelley
ColinDKelley reviewed Aug 17, 2020
View reviewed changes
lib/contextual_logger.rb Outdated Show resolved Hide resolved
lib/contextual_logger.rb Outdated Show resolved Hide resolved
ColinDKelley
ColinDKelley approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@ColinDKelley ColinDKelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one remaining comment about getting json into the method name.

@jebentier jebentier merged commit 43c354f into master Aug 17, 2020
@jebentier jebentier deleted the TECH-4608_remove_unnecessary_timestamps branch August 17, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinDKelley ColinDKelley ColinDKelley approved these changes

Assignees

@jebentier jebentier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jebentier @ColinDKelley