Tech 4747 update contextual logger to normalize context keys to symbols

[yinonrousso]

Jira Ticket

Description

Update contextual logger to normalize keys to symbols and warn on string keys

Gotchas

None

For the Code Reviewer:

• The post deploy checks have been reviewed

[ColinDKelley]

@yinonrousso Our Ruby coding standards say to use parentheses around arguments unless it's a Domain Specific Language.

https://github.com/Invoca/style-guide/tree/master/ruby#omit-parentheses-around-parameters-for-methods-that-are-part-of-an-internal-dsl

Also, we only use trailing if/unless if it's a rare footnote that normally executes the preceding code.

https://github.com/Invoca/style-guide/tree/master/ruby#only-use-trailing-ifunless-when-they-are-rare-footnotes-that-can-be-ignored-in-the-usual-go-right-case

And the code is jammed up on one line. Here it is spread out a bit:

hash.keys.any? { |key| key.is_a?(String) } ||
   hash.any? { |key, value| (value.is_a?(Hash) && deep_key_has_string?(value) }

That's the same as:

hash.any? { |key, value| key.is_a?(String) } ||
   hash.any? { |key, value| (value.is_a?(Hash) && deep_key_has_string?(value) }

There's obviously no need to walk the hash twice!

hash.any? do |key, value|
  key.is_a?(String) } ||
    (value.is_a?(Hash) && deep_key_has_string?(value))
end

[yinonrousso]

Thank you, I'll make the appropriate changes 👍