Skip to content

Commit

Permalink
Re-add URL detection because of faulty CodeIgniter detection after 1.…
Browse files Browse the repository at this point in the history 
…4.8 release
  • Loading branch information
@Kovah
Kovah committed Aug 1, 2016
1 parent 797a519 commit 6c1cb13
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion application/config/config.php
View file
Expand Up @@ -14,7 +14,8 @@
| path to your installation.
|
*/
$config['base_url'] = '';
$config['protocol'] = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on' ? 'https://' : 'http://');
$config['base_url'] = $config['protocol'] . ($_SERVER['HTTP_HOST'] ? $_SERVER['HTTP_HOST'] : $_SERVER['SERVER_NAME']) . URL_SUBFOLDER;

/*
|--------------------------------------------------------------------------
Expand Down

6 comments on commit 6c1cb13

@MarcinWieczorek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change 1.4.8 release tag to this?

@Kovah
Copy link
Contributor Author

@Kovah Kovah commented on 6c1cb13 Aug 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because the app wasn't working correctly with the original state

@MarcinWieczorek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it broke the package in AUR.
Would you mind sending me an email next time?

@Cronus89
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just upgraded to 1.4.8 and this broke IIS, it adds the complete filesystem path to the url i.e. /c/inetpub/ etc etc.

@Kovah
Copy link
Contributor Author

@Kovah Kovah commented on 6c1cb13 Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace $config['base_url'] = ''; with $config['base_url'] = 'http://yourdomainhere.com';

@Cronus89
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it myself, Was just letting you know this breaks default functionality since you now have the base_url set to
$config['base_url'] = $config['protocol'] . ($_SERVER['HTTP_HOST'] ? $_SERVER['HTTP_HOST'] : $_SERVER['SERVER_NAME']) . URL_SUBFOLDER;

Please sign in to comment.