[IP-254] Receipts for payments #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No matter how the proportions of the logo were, it was always displayed as fixed 80x80px - this looked distorted if the logo is e.g. 200x40px.
IP-312 - Current logged in user not displayed
IP-315 - Array definition incompatible with PHP < 5.4
IP-291 - Let CodeIgniter also accept new domain names
IP-310 - Taxes and products do not respect separator and decimal
Added invoice footer also to quotes
fix logo upload image width/height proportions
Getting the start of a vm for invoiceplane
Updating readme
IP-316 Feature/vagrant ansible
The start of the payment gateway integrations. Work in progress!
IP-293 - Custom title for public view of quotes / invoices
udpate to upstream
show real server name at end of setup
show (http(s)) protocol in setup complete procedure
IP-318 - Support for variables in product / item names
IP-360 - Implemented mPDF template file
IP-104 - Custom fields are not copied when Invoice is duplicated
With this small add the client's import process fills all the fields. if you accept this change you may have to update also the columns reference in https://wiki.invoiceplane.com/en/1.0/system/importing-data adding the relative two columns.
Update mdl_import.php
Conflicts: application/helpers/pdf_helper.php
IP-109: Added suport for having a custom template for each invoice group
New lines to html br in guest quote view
New lines to html br in guest quote view
IP-400 fix null password PDF protection
IP-400 fix null password PDF protection
|
Thank you for your pull request! 🎉 |
mihaimatei
force-pushed
the
IP-254-Receipts-rebasedon-development
branch
from
b00006a
to
61692a4
Compare
|
@Kovah , sorry for the delay, I've rebase first time got me with a lot of conflicts and others commits, I don't know why, but probably because I've started based on v1.4.4 or something was not up to date. |
kalimerre
requested changes
Nov 7, 2017
| <?php echo format_currency($invoice_tax_rate->invoice_tax_rate_amount); ?> | ||
| </td> | ||
| </tr> | ||
| <?php endforeach ?> |
There was a problem hiding this comment.
It miss the ";" after the endforeach
| <h1 class="invoice-title"><?php echo lang('receipt') . ' ' . $payment->receipt_number; ?></h1> | ||
| <div id="company"> | ||
| <div><b><?php echo $invoice->user_company; ?></b></div> | ||
| <?php if ($invoice->user_vat_id) |
There was a problem hiding this comment.
Would be great to use the same format as line 19 for example. It's a template and most of users are not developers so it will be hard to understand the condition for them
if(condition) {
echo "blabla";
}
|
Needs to be rebased on top of 1.6.0 to include it in version 1.6.0. |
|
Needs label : 1.6 or 1.5.11 or something. Needs Milestone? |
nielsdrost7
force-pushed
the
development
branch
from
04a876d
to
db24211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented receipts tied to payment method, as follows:
It is designed to support partial payments, so multiple receipts for each invoice.
I've added changes to the PDF template from branch 1.4.6, and marked the added lines between comment :|, sorry for that.
Database changes summary:
The SQL queries should be moved into the proper next release sql setup file, now it's in 017_1.4.4-nextRelease.sql
More info in the Jira ticket comment: https://development.invoiceplane.com/browse/IP-254