Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IP-625] Bugfix some wrong columns and index #578

Closed
wants to merge 2 commits into from

Conversation

franciscorangel
Copy link

Bugfix some parts of the code, changing all parts to the new column names, this problem started when I have done a update 1.4.x to 1.5.x

Update code to accept composite primary keys and work with invoice custom.
Alter some tables to new column name.

Changed a primary key index.

…ames.

Update code to acept composite primary keys and work with invoice custom.
Alter some tables to new column name.
Changed a primary key indice.
@Kovah
Copy link
Contributor

Kovah commented Dec 10, 2017

@denysvitali Could you check these changes for the custom fields?

@denysvitali
Copy link
Member

I've read the code, and it looks ok to me. I still have to test it though. I'll take a look at it this week

@franciscorangel
Copy link
Author

franciscorangel commented Dec 11, 2017

I've added other bugfix related, now enable to save custom field with empty value.

@Kovah
Copy link
Contributor

Kovah commented Apr 9, 2018

@franciscorangel Could you outline what exactly the problem was and which errors occured while migrating from 1.4 to 1.5? Would like to know more about this as custom fields were working perfectly for me and did not encounter any errors.

@Kovah Kovah added this to the 1.6.0 milestone Apr 9, 2018
@Kovah
Copy link
Contributor

Kovah commented Jun 28, 2018

@franciscorangel Any news?

@Kovah Kovah changed the title [IP-625] - Bugfix some wrong columns and index [IP-625] Bugfix some wrong columns and index Jun 28, 2018
@miquel-cabanas
Copy link
Contributor

I cannot reproduce the problem in v.5.9 and v1.5.10.

Apparently this PR is no longer needed and may conflict with the code in v1.5.9/v1.5.10 (there is already a column named 'client_custom_fieldid') and/or in CI (changes to application/core/MY_Model.php).

I recommend rejecting this PR as no longer needed for v1.5.10.

@Kovah Kovah closed this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants