Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show upload-path #739

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Don't show upload-path #739

merged 1 commit into from
Jun 18, 2021

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Jun 13, 2021 •
edited

This is the quick fix for #734

As the full path is never used, we just decided to remove it entirely and not show it at all.

@zeitschlag zeitschlag changed the base branch from master to develop June 13, 2021 16:39
clockwiseq
clockwiseq approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@clockwiseq clockwiseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Reviewing the original code, I'm also not sure why the full path was included.

@zeitschlag zeitschlag merged commit 4b718b5 into InvoicePlane:develop Jun 18, 2021
@zeitschlag zeitschlag deleted the 734-file-upload-path branch June 18, 2021 12:39
@zeitschlag zeitschlag mentioned this pull request Jul 23, 2021
Closed
5 tasks
@nielsdrost7 nielsdrost7 mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clockwiseq clockwiseq clockwiseq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeitschlag @clockwiseq