[IP-711] Add responsive view for invoices/quotes #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Branch 1.5.12 Your branch is up-to-date with 'upstream/1.5.12'. zum Commit vorgemerkte Änderungen: geändert: application/language/english/ip_lang.php gelöscht: application/modules/invoices/views/partial_item_table.php geändert: application/modules/invoices/views/view.php geändert: application/modules/products/views/modal_product_lookups.php gelöscht: application/modules/quotes/views/partial_item_table.php geändert: application/modules/quotes/views/view.php geändert: application/modules/settings/views/partial_settings_general.php geändert: application/modules/tasks/views/modal_task_lookups.php geändert: assets/invoiceplane/sass/_custom_styles.scss geändert: composer.lock Unversionierte Dateien: application/modules/invoices/views/partial_itemlist_responsive.php application/modules/invoices/views/partial_itemlist_table.php application/modules/quotes/views/partial_itemlist_responsive.php application/modules/quotes/views/partial_itemlist_table.php
Ihr Branch ist 1 Commit vor 'upstream/1.5.12'. zum Commit vorgemerkte Änderungen: geändert: application/language/english/ip_lang.php geändert: application/modules/invoices/views/partial_itemlist_responsive.php geändert: application/modules/quotes/views/partial_itemlist_responsive.php - fixed indentation - replaced short open tags - removed tags around divs - added missing labels and input types
indentation
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| <span class="text-muted"> | ||
| <?php echo htmlsc($quote_tax_rate->quote_tax_rate_name) . ' ' . format_amount($quote_tax_rate->quote_tax_rate_percent) ?> | ||
| </span> | ||
| <button type="submit" class="btn btn-xs btn-link" onclick="return confirm('<?php _trans('delete_tax_warning'); ?>');"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
nielsdrost7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Issue Type (Please check one or more)