Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape client name for PDF generation (Only in Zugferd invoices) #810

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Escape client name for PDF generation (Only in Zugferd invoices) #810

merged 1 commit into from
Apr 18, 2022

Conversation

Forceu
Copy link
Contributor

@Forceu Forceu commented Apr 17, 2022 •
edited

This PR fixes the issue #809. If the client name has an & in their name, it would break PDF generation otherwise.

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@Forceu
Copy link
Contributor Author

Forceu commented Apr 17, 2022

Fixes #809

@Forceu Forceu changed the title Escape client name Escape client name for PDF generation Apr 17, 2022
@clockwiseq clockwiseq linked an issue Apr 18, 2022 that may be closed by this pull request
[ONLY Zugferd invoices] Client name is not escaped during PDF generation #809
Closed
@UnderDogg UnderDogg changed the base branch from master to develop April 18, 2022 07:04
@nielsdrost7 nielsdrost7 mentioned this pull request Apr 18, 2022
Closed
@nielsdrost7 nielsdrost7 changed the title Escape client name for PDF generation Escape client name for PDF generation (Only in Zugferd invoices) Apr 18, 2022
@nielsdrost7 nielsdrost7 merged commit a7edf37 into InvoicePlane:develop Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ONLY Zugferd invoices] Client name is not escaped during PDF generation
2 participants
@Forceu @nielsdrost7