Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display $client surname for recurring invoices #811

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

giacy86
Copy link
Contributor

@giacy86 giacy86 commented Apr 25, 2022

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature
    As title, in the page /invoices/recurring/index is useful to have the clients surname too.

Select appropriate pdf template for guest users "download pdf" button.
Select appropriate pdf template for guest users
@clockwiseq clockwiseq added the Feature Request Improvement or Feature Request label Apr 25, 2022
@clockwiseq clockwiseq added this to In progress in Invoice Plane (v1) via automation Apr 25, 2022
@nielsdrost7 nielsdrost7 changed the base branch from master to develop April 25, 2022 19:52
@nielsdrost7
Copy link
Contributor

Thank you for the pull-request.
You're trying to resolve 2 problems in 1 PR:

  1. Select a template for a gues user
  2. Add a surname

Next time, please make 2 separate PR'S. Solution 1 has some impact.

@nielsdrost7 nielsdrost7 merged commit 320e5fb into InvoicePlane:develop Apr 25, 2022
Invoice Plane (v1) automation moved this from In progress to Done Apr 25, 2022
@giacy86
Copy link
Contributor Author

giacy86 commented Apr 26, 2022

Thank you for the pull-request.

You're trying to resolve 2 problems in 1 PR:

  1. Select a template for a gues user

  2. Add a surname

Next time, please make 2 separate PR'S. Solution 1 has some impact.

Sorry, I'm a bit confused with pull requests. Previously I have created a PR for select pdf template for guest user

@clockwiseq
Copy link
Contributor

Thank you for the pull-request.
You're trying to resolve 2 problems in 1 PR:

  1. Select a template for a gues user
  2. Add a surname

Next time, please make 2 separate PR'S. Solution 1 has some impact.

Sorry, I'm a bit confused with pull requests. Previously I have created a PR for select pdf template for guest user

He approved and merged this one, but next time, each issue needs to be in it's own PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Improvement or Feature Request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants