Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for outdated card data handling #814 #816

Merged
merged 13 commits into from
Jul 10, 2022
Merged

Fix for outdated card data handling #814 #816

merged 13 commits into from
Jul 10, 2022

Conversation

naui95
Copy link
Contributor

@naui95 naui95 commented Jun 11, 2022 •
edited
Loading

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request. (FEATURE - Stripe Integration Outdated #814 )
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

naui95 and others added 13 commits June 11, 2022 20:52
@naui95
Copy link
Contributor Author

naui95 commented Jun 11, 2022

Basic changes are:

  • based on dropdown select (which therefore must have a "none" value) the stripe.js form is loaded
  • the stripe.js form generates the token for the payment that is then used in the usual process

this solution allows the secure handling of card data without changing the current structure.

@nielsdrost7 nielsdrost7 merged commit f2b5120 into InvoicePlane:develop Jul 10, 2022
This was referenced Jul 31, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naui95 @nielsdrost7