Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading stripe for websites not using clean urls (#883) #896

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

naui95
Copy link
Contributor

@naui95 naui95 commented Dec 7, 2022

Description

known issue was not completely solved in beta version. Stripe library is now loaded by passing a php script instead of injecting js directly. IP must therefore use site_url variable instead of base_url.

Related Issue

#883

Pull Request Checklist

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@naui95 naui95 added this to the 1.6.1 milestone Dec 7, 2022
@naui95 naui95 linked an issue Dec 7, 2022 that may be closed by this pull request
@nielsdrost7 nielsdrost7 merged commit 599c655 into development Dec 7, 2022
@nielsdrost7 nielsdrost7 deleted the issue-883-1 branch March 10, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error loading stripe script on payment page
2 participants