In version 1.6.0 the logo isn't shown on the PDF #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 1.6.0 the logo isn't shown on the PDF invoice. When changing line 39 the logo returns.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| @@ -36,7 +36,7 @@ function invoice_logo_pdf() | |||
| $CI = &get_instance(); | |||
|
|
|||
| if ($CI->mdl_settings->setting('invoice_logo')) { | |||
| return '<img src="file://' . getcwd() . '/uploads/' . $CI->mdl_settings->setting('invoice_logo') . '" id="invoice-logo">'; | |||
| return '<img src="' . base_url() . 'uploads/' . $CI->mdl_settings->setting('invoice_logo') . '" id="invoice-logo">'; | |||
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
|
Thanks for the PR man! I've merged it into the development branch since we need it for the next version |
Closed
5 tasks
Closed
5 tasks
nielsdrost7
changed the title
|
Thanks! This fix worked for me. |
|
get someone help me ? os: alpine 3.18 |
|
@mohamad-supangat Did you use docker to start your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.6.0 the logo isn't shown on the PDF invoice. When changing line 39 the logo returns.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Pull Request Checklist
Issue Type (Please check one or more)