Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inserting email template #900

Merged
merged 2 commits into from Dec 22, 2022
Merged

Conversation

mheiduk
Copy link
Contributor

@mheiduk mheiduk commented Dec 21, 2022

Description

When selecting an email template on the 'send invoice' page, it won't get inserted into the textarea. val() instead of html() has to be used here.

Motivation and Context

Fixes the above mentioned issue.

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

When selecting an email template, it won't get inserted into the textarea. val() instead of html() has to be used here.
@nielsdrost7
Copy link
Contributor

Thanks for the PR, it's merged into the development branch.

@nielsdrost7 nielsdrost7 merged commit a9a5362 into InvoicePlane:development Dec 22, 2022
@bminer
Copy link

bminer commented Jul 31, 2023

Does this solve #962?

@nielsdrost7
Copy link
Contributor

nielsdrost7 commented Jul 31, 2023

@bminer This PR was created in December of 2022 and issue #962 was created after that.
For the issue with the <style> tags in the email templates there are 2 solutions:

  1. Documentation: "Please do not use style tags in your templates"
  2. strip the style tags after the user submits his template

We'll fist have to reproduce the problem thanks to your excellent steps to reproduce.
You can try the solution (see the files tab), but I think we need to wait for the solution where we strip the styles from the html

@bminer
Copy link

bminer commented Jul 31, 2023

I helped create #962, and it applies to 1.6.0. This PR #900 was incorporated into one of the 1.6.0-beta versions that I've not tried. That's why I was asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants