Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP-940: unicode inside select #950

Merged
merged 1 commit into from May 20, 2023
Merged

IP-940: unicode inside select #950

merged 1 commit into from May 20, 2023

Conversation

KelvinCodesStuff
Copy link
Contributor

@KelvinCodesStuff KelvinCodesStuff commented May 20, 2023 •
edited by nielsdrost7

Related Issue

addresses #940

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type

  • Bugfix

@nielsdrost7 nielsdrost7 self-requested a review May 20, 2023 13:12
@nielsdrost7 nielsdrost7 changed the title bugfix/IP-940-unicode-inside-select IP-940: unicode inside select May 20, 2023
nielsdrost7
nielsdrost7 approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@nielsdrost7 nielsdrost7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! And you've squashed your commits, awesome!👌

@nielsdrost7 nielsdrost7 merged commit 0310314 into InvoicePlane:development May 20, 2023
1 check passed
@KelvinCodesStuff KelvinCodesStuff mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdrost7 nielsdrost7 nielsdrost7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KelvinCodesStuff @nielsdrost7