Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

own env option for 'sess_save_path' #984

Merged

Conversation

mheiduk
Copy link
Contributor

@mheiduk mheiduk commented Sep 18, 2023

Description

Adding possibility to easily change the path for the option 'sess_save_path' via an env variable.

Related Issue

#935
https://community.invoiceplane.com/t/topic/10166

Motivation and Context

At the moment a change isn't possible unless changing it directly in the config.php file. Should be available as an env option too in my opinion.

Screenshots (if appropriate):

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@mheiduk mheiduk changed the title own env option for 'sess_save_path' #935 own env option for 'sess_save_path' Sep 18, 2023
@nielsdrost7
Copy link
Contributor

nielsdrost7 commented Sep 18, 2023

Thank you very much for the PR. I'll merge it for sure.
I was just thinking about 2 things:
The value in ipconfig.php.example. What should we put there?
Should we put this line in ipconfig.php.example?

Could you rebase 1 more time?
I've made a change in the development branch yesterday.
The exact same file

@mheiduk
Copy link
Contributor Author

mheiduk commented Sep 19, 2023

Already should have been rebased, I can see your commit in my branch.

I can put the line in ipconfig.php.example, but other env vars are missing too. If you want, I can also add the missing env vars and then we could merge.

@nielsdrost7
Copy link
Contributor

Already should have been rebased, I can see your commit in my branch

You're right,my apologies.

I've decided against adding those other variables in the ipconfig.php.example file.
It could give more unnecessary questions.

Great job!
I'm merging your PR

@nielsdrost7 nielsdrost7 merged commit 2c124b4 into InvoicePlane:development Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants