Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Company VAT-ID and Tax-ID #54

Merged
merged 7 commits into from
Apr 20, 2024
Merged

Add Company VAT-ID and Tax-ID #54

merged 7 commits into from
Apr 20, 2024

Conversation

Timo972
Copy link

@Timo972 Timo972 commented Apr 13, 2024

This PR adds the vat_id and tax_id field to the company model alongside the necessary input fields in the vue frontend

gdarko
gdarko requested changes Apr 16, 2024
View reviewed changes
Copy link

@gdarko gdarko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Timo972 - Nice job. Can you please make those fields nullable? Thanks.

Also, please make sure to run:

  1. Fix code style
vendor/bin/pint
  1. Run tests and make sure they pass
vendor/bin/pest

@Timo972 Timo972 requested a review from gdarko April 16, 2024 10:44
gdarko
gdarko approved these changes Apr 16, 2024
View reviewed changes
Copy link

@gdarko gdarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@gdarko gdarko merged commit 8c83df5 into InvoiceShelf:master Apr 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdrost7 nielsdrost7 nielsdrost7 left review comments

@gdarko gdarko gdarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timo972 @gdarko @nielsdrost7