Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3 compatible storage services #56

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Timo972
Copy link

@Timo972 Timo972 commented Apr 14, 2024

This PR adds support for s3 compatible storage services.

@gdarko
Copy link

gdarko commented Apr 16, 2024

Hey @Timo972 ,

I tested this with Wasabi and it looks fine. Have you used another provider? Curious which one :-). I am trying to document the support for those providers.

Also, please fix the code style because the workflow fails for wrong code style. You can run the following command to fix it:

vendor/bin/pint

Best,
Darko

@Timo972
Copy link
Author

Timo972 commented Apr 16, 2024

Hi @gdarko, I used a self hosted Minio instance.
Best regards

@gdarko gdarko merged commit dc8a855 into InvoiceShelf:master Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants