-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New object endpoints #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Would like to hear your thoughts on how to clean up the subscription preview endpoint.
@@ -10,5 +10,11 @@ class Subscription < Object | |||
def cancel | |||
delete | |||
end | |||
|
|||
def preview(params={}, opts={}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a similar comment here as the PHP library about returning a JSON object, i.e. https://github.com/Invoiced/invoiced-ruby/blob/master/lib/invoiced/customer.rb#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in same manner as PHP library
New objects: Coupon, Letter, Note, Task, TaxRate, TextMessage