Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New object endpoints #14

Merged
merged 12 commits into from
Nov 11, 2019
Merged

New object endpoints #14

merged 12 commits into from
Nov 11, 2019

Conversation

adam-invoiced
Copy link
Contributor

New objects: Coupon, Letter, Note, Task, TaxRate, TextMessage

@coveralls
Copy link

coveralls commented Nov 5, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a356d79 on new-endpoints into 8c2fe4c on master.

Copy link
Contributor

@jaredk2g jaredk2g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Would like to hear your thoughts on how to clean up the subscription preview endpoint.

@@ -10,5 +10,11 @@ class Subscription < Object
def cancel
delete
end

def preview(params={}, opts={})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a similar comment here as the PHP library about returning a JSON object, i.e. https://github.com/Invoiced/invoiced-ruby/blob/master/lib/invoiced/customer.rb#L18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in same manner as PHP library

lib/invoiced/util.rb Outdated Show resolved Hide resolved
@jaredk2g jaredk2g merged commit 60b1cb1 into master Nov 11, 2019
@jaredk2g jaredk2g deleted the new-endpoints branch November 11, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants