New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect on Error #7
base: master
Are you sure you want to change the base?
Conversation
1 similar comment
Travis error was a composer error, unrelated to this PR, I believe. |
Thank you for the contribution! Can you add a test case for when the redirectOnError parameter is used? |
No problem. I realised after coveralls reported -2.5% C.C. that I hadn't included any tests with it. Been a pretty busy day but I'll get it sorted. Cheers. |
Sorry it's taken me so long to get around to it, I'm sure you know how it is 😅 |
Sorry about that. I had to remove a typehint to get the PHP5.6 tests to pass. |
Thank you for the PR! Can you add a test case for |
A project I'm working on requires that the user be redirected back to my application if the user hits cancel in Xero's OAuth.
Luckily this is handled nicely by a request parameter.
See "Redirect on Error", here.
I've added the parameter to the Xero class and defaulted it to false.
Usage is pretty simple:
Now if the Xero part of OAuth fails for any reason (User hits cancel, can't remember password etc.), Xero will redirect us back to the application's callback url.