Skip to content

Commit

Permalink
PR name changes and fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Ferparishuertas committed Sep 16, 2019
1 parent 2708885 commit ff31dbe
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions contracts/Holdable.sol
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ contract Holdable is IHoldable, ERC20 {


if (keepOpenIfHoldHasBalance && ((executableHold.value - value) > 0)) {
_decreaseHeldBalanceWithDefinedValue(operationId, value);
_decreaseHeldBalance(operationId, value);
_setHoldToExecutedAndKeptOpen(operationId, value);
}else {
_decreaseHeldBalanceWithDefinedValue(operationId, executableHold.value);
_decreaseHeldBalance(operationId, executableHold.value);
_setHoldToExecuted(operationId, value);
}

Expand Down Expand Up @@ -328,7 +328,7 @@ contract Holdable is IHoldable, ERC20 {
);
}
function _decreaseHeldBalanceWithDefinedValue(string memory operationId, uint256 value) internal {
function _decreaseHeldBalance(string memory operationId, uint256 value) internal {
Hold storage executableHold = holds[operationId.toHash()];
heldBalance[executableHold.origin] = heldBalance[executableHold.origin].sub(value);
_totalHeldBalance = _totalHeldBalance.sub(value);
Expand Down

0 comments on commit ff31dbe

Please sign in to comment.