Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0/0 ==> -nan #406

Closed
yangfl opened this issue May 29, 2018 · 1 comment
Closed

0/0 ==> -nan #406

yangfl opened this issue May 29, 2018 · 1 comment

Comments

@yangfl
Copy link
Contributor

yangfl commented May 29, 2018

Is that correct?

It causes test to fail in #217 and #22 in which "" asNumber is nan but Number constants nan is actually -nan.
@stevedekorte
Copy link
Member

Hi yangfl, That doesn't sound good. Would you like to submit a pull request for the fix?

stevedekorte added a commit that referenced this issue May 30, 2018
@stevedekorte
Merge pull request #408 from yangfl/upstream
fae4f12 
iovm: fix negative NANs, fix #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevedekorte @yangfl