Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36 create mariadb service in new docker compose file #37

Merged
merged 15 commits into from
Feb 19, 2024

Conversation

Iodine98
Copy link
Owner

This PR has the following additions:

  • Add init.sql file to initialize the user of the MariaDB instance with sufficient rights
  • Updated the README.md to include information about the new env. variables regarding the MariaDB instance
  • Refactored models.py to include the original answer and adhere to the MariaDB dialect.

@Iodine98 Iodine98 linked an issue Feb 15, 2024 that may be closed by this pull request
@Iodine98 Iodine98 self-assigned this Feb 15, 2024
@Iodine98
Copy link
Owner Author

Hi @Toppertje, kan je kijken of de configuratie een MariaDB goed gegaan is? Btw, zouden wij de vectorDB at runtime inrichten of ook koppelen aan persistent storage? Het fijnste zou namelijk zijn als ik zelf de vectorDB zou kunnen benaderen.

@Toppertje
Copy link

Toppertje commented Feb 15, 2024 via email

@Iodine98
Copy link
Owner Author

Hi Rohan, Op welk platform draait deze vectorDB? Is dat ook MariaDB? @Toppertje

Aangezien MariaDB geen VectorDB is, heb ik tot nu Chroma gebruikt met een persistentclient die een map creëert met embeddings in de server container. Voor scalability en persistency lijkt het mij handig om hiervoor een aparte container te later draaien in Docker. Zie de documentatie van Chroma op Docker.
Graag hoor ik wat je ervan vindt.

Mvg,

Rohan

@Iodine98
Copy link
Owner Author

lgtm

@Iodine98 Iodine98 merged commit e108c5a into main Feb 19, 2024
1 check passed
@Iodine98 Iodine98 deleted the 36-create-mariadb-service-in-new-docker-compose-file branch February 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MariaDB service in new Docker Compose file
2 participants