Skip to content

Commit

Permalink
fix: remove unnecessary payable modifiers to reduce risk of locked ether
Browse files Browse the repository at this point in the history
  • Loading branch information
HrikB committed Jan 2, 2024
1 parent 98e2825 commit 70dc90d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/admin/TransparentUpgradeableProxy.sol
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ contract TransparentUpgradeableProxy is ERC1967Proxy {
* backed by the implementation at `_logic`, and optionally initialized with `_data` as explained in
* {ERC1967Proxy-constructor}.
*/
constructor(address _logic, address initialOwner, bytes memory _data) payable ERC1967Proxy(_logic, _data) {
constructor(address _logic, address initialOwner, bytes memory _data) ERC1967Proxy(_logic, _data) {
ADMIN = address(new ProxyAdmin(initialOwner));
// Set the storage value and emit an event for ERC-1967 compatibility
ERC1967Utils.changeAdmin(_proxyAdmin());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ abstract contract BalancerFlashloanDirectMintHandler is IonHandlerBase, IFlashLo
uint256 maxResultingDebt
)
external
payable
{
LST_TOKEN.safeTransferFrom(msg.sender, address(this), initialDeposit);

Expand Down
2 changes: 1 addition & 1 deletion src/periphery/IonZapper.sol
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ contract IonZapper {
POOL.repay(ilkIndex, msg.sender, msg.sender, normalizedAmountToRepay);
}

function zapDepositWstEth(uint256 amountStEth) external payable {
function zapDepositWstEth(uint256 amountStEth) external {
STETH.transferFrom(msg.sender, address(this), amountStEth);

uint256 outputWstEthAmount = WSTETH.wrap(amountStEth);
Expand Down

0 comments on commit 70dc90d

Please sign in to comment.