Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-03 (OZ Audit) #34

Merged
merged 5 commits into from Jan 18, 2024
Merged

N-03 (OZ Audit) #34

merged 5 commits into from Jan 18, 2024

Conversation

HrikB
Copy link
Collaborator

@HrikB HrikB commented Jan 5, 2024

Removing magic values in general.

But especially, removing the magic value for the balancer poolId inside UniswapFlashloanBalancerSwapHandler. This should not be hardcoded and is now parameterized through the constructor.

@HrikB HrikB mentioned this pull request Jan 5, 2024
@HrikB HrikB merged commit e90a06a into master Jan 18, 2024
@HrikB HrikB deleted the hrikb/N-03 branch January 18, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant