Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink text getting doubled each time click on link #25

Closed
1 of 2 tasks
Gajendran7 opened this issue Sep 3, 2018 · 8 comments
Closed
1 of 2 tasks

Hyperlink text getting doubled each time click on link #25

Gajendran7 opened this issue Sep 3, 2018 · 8 comments
Labels

Comments

@Gajendran7
Copy link

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

  1. Navigate to editor and enter some link
  2. Select the link and click on link icon in header (multiple times)

Version information

Browser type and version: Chrome (Desktop) - Latest version
EasyMDE version: NA
2018-09-03_19-37-42

@Ionaru
Copy link
Owner

Ionaru commented Sep 3, 2018

The demo site uses the older SimpleMDE editor. Can you reproduce this with a more recent version?

(Still need to build a new demo website, sorry!)

@Jetski5822
Copy link

Yeah - it repros locally too using the latest editor here :(

@Ionaru
Copy link
Owner

Ionaru commented Oct 15, 2018

Alright I've tracked down the issue, but what do you expect to happen when you click on the link button in this situation?

Should the link be removed or should nothing happen?

@Ionaru Ionaru added the Bug label Oct 15, 2018
@n-3-0
Copy link

n-3-0 commented Oct 17, 2018

I would think that, since the link button is highlighted, it should behave consistently with other buttons and act as a toggle, removing the link.

@danielok1993
Copy link

I have added toggling for links and images. I will submit pull request soon 👍

@nerg4l
Copy link

nerg4l commented Dec 10, 2020

@danielok1993 Are you still planning to make a PR?

@danielok1993
Copy link

@nerg4l this was long ago, but I did make a PR. You can view it in the Pull Request section and copy what I have implemented, as my PR was not merged.

@nerg4l
Copy link

nerg4l commented Dec 10, 2020

Thanks for the info @danielok1993, I found it #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants