New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link and image toggle #281

Closed

nerg4l wants to merge 1 commit into Ionaru:master from nerg4l:bugfix/link-toggle

nerg4l commented Dec 23, 2020

Related #25, #95

I fixed the conflicts in the previous PR and played with it. I had to change it a bit because it acted weirdly when a link contained an image.

It requires a negative lookbehind which was introduced in ES2018. This might changes the requirements of the lib.
The replacement is not perfect because a link/image is recognise by the toolbar when the cursor is before a [ or after a ] char.

Probably a different handling would be more appropriate.


          Fix link and image toggle

13dea5c

Ionaru closed this in

c84af4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment