Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving fullscreen mode does not make side-by-side view disappear #306

Open
Situphen opened this issue Feb 21, 2021 · 5 comments
Open

Leaving fullscreen mode does not make side-by-side view disappear #306

Situphen opened this issue Feb 21, 2021 · 5 comments
Labels

Comments

@Situphen
Copy link

Situphen commented Feb 21, 2021

Describe the bug

If you are in fullscreen mode with side-by-side view and you leave fullscreen mode, the side-by-side previsualization stays on half the page

To Reproduce
Steps to reproduce the behavior:

  1. With sideBySideFullscreen set to false
  2. Go fullscreen mode
  3. Activate side-by-side view
  4. Leave fullscreen mode

Expected behavior
Side-by-side view should either disappear or be restricted to the editor

Screenshots
Screenshot of the issue

** Version information **

  • OS: Ubuntu Budige 20.04
  • Browser: Firefox 85
  • EasyMDE version: 2.14.0

Additional context
Add any other context about the problem here.

@Situphen Situphen added the Bug label Feb 21, 2021
@Situphen
Copy link
Author

I am not reproducing on https://easy-markdown-editor.tk/ so I guess the issue is on my side, so I am closing for now.

@Situphen
Copy link
Author

I am reopening because I can reproduce it on https://easy-markdown-editor.tk/ when sideBySideFullscreen option is set to false.

Screenshot of the issue

@Situphen Situphen reopened this Feb 21, 2021
@Ionaru
Copy link
Owner

Ionaru commented Feb 21, 2021

@Situphen Can you please describe the steps you took to reproduce it?

@Situphen
Copy link
Author

You can use this code:

new EasyMDE({
    autoDownloadFontAwesome: false,
    element: document.getElementById('mde-demo'),
    initialValue: '# EasyMDE \n Go ahead, play around with the editor! Be sure to check out **bold**, *italic* and ~~strikethrough~~ styling, [links](https://google.com) and all the other features. You can type the Markdown syntax, use the toolbar, or use shortcuts like `ctrl-b` or `cmd-b`.',
    sideBySideFullscreen: false
});

And try these steps:

  1. Click the Toogle Fullscreen (F11) button to enter fullscreen
  2. Click the Toogle Side by Side (F9) button to enable side by side mode
  3. Click the Toogle Fullscreen (F11) button again to leave fullscreen

@smundro
Copy link

smundro commented Mar 15, 2021

This appears related to my #286 PR, which stopped toggling side-by-side when toggling fullscreen when sideBySideFullscreen=false, which apparently leads to the side-by-side state getting out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants