don't toggle preview if sideBySideFullscreen is false #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggling fullscreen causes the enabled side-by-side preview to be hidden when
sideBySideFullscreen === false. This change causes the editor to ignore the preview state when the default "side-by-side requires fullscreen" option is disabled.(Long story: default behavior was to trigger full screen when enabling side-by-side preview, an option was added to allow for side-by-side preview without full screen, but didn't account for existing side-by-side handling when toggling fullscreen, which was [apparently] intended to ensure it was toggled off when returning from fullscreen.)