Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Correctly keep preview active during fullscreen-toggle #316

Merged
merged 16 commits into from Mar 27, 2021
Merged

Bugfix: Correctly keep preview active during fullscreen-toggle #316

merged 16 commits into from Mar 27, 2021

Commits on Mar 15, 2021

  1. bugfix: move sidebyside accessor outside of options check

    @smundro
    smundro committed Mar 15, 2021
    Copy the full SHA
    abbec5b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. handle fullscreen toggle consistently by adusting toggleSideBySide

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    61e93a3 View commit details
    Browse the repository at this point in the history

  2. code refactoring to improve readability

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    fa8855e View commit details
    Browse the repository at this point in the history

  3. correct test page title

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    8702dd2 View commit details
    Browse the repository at this point in the history

  4. more code cleanup for readibilty

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    25db654 View commit details
    Browse the repository at this point in the history

  5. make toggle cleanup flag clearer

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    8ed6cd6 View commit details
    Browse the repository at this point in the history

  6. undo some comment changes to make diff cleaner

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    d76872f View commit details
    Browse the repository at this point in the history

  7. Move from multiple "no-fullscreen" classes to one using inheritance

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    7069fd1 View commit details
    Browse the repository at this point in the history

  8. clean up diff

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    d636eb7 View commit details
    Browse the repository at this point in the history

  9. clarify comments in togglePreview

    @smundro
    smundro committed Mar 16, 2021
    Copy the full SHA
    4533dd4 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Unwind all the onlyCleanup stuff and set classes directly.

    @smundro
    smundro committed Mar 17, 2021
    Copy the full SHA
    1ee8519 View commit details
    Browse the repository at this point in the history

  2. a little comment/cleanup

    @smundro
    smundro committed Mar 17, 2021
    Copy the full SHA
    d0f6939 View commit details
    Browse the repository at this point in the history

  3. remove extra comment updates

    @smundro
    smundro committed Mar 17, 2021
    Copy the full SHA
    40ddcea View commit details
    Browse the repository at this point in the history

  4. remove added comment

    @smundro
    smundro committed Mar 17, 2021
    Copy the full SHA
    548229d View commit details
    Browse the repository at this point in the history

  5. restore removed comment

    @smundro
    smundro committed Mar 17, 2021
    Copy the full SHA
    82a8e4a View commit details
    Browse the repository at this point in the history

  6. Add simple class handling utiltity to DRY adding/removing class names. 

    Note that this isn't necessary and can be rolled back, but could be used throughout the code to make class handling more clear and consistent.
    @smundro
    smundro committed Mar 17, 2021
    Copy the full SHA
    b61fe79 View commit details
    Browse the repository at this point in the history