Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove class name from buttons #465

Closed
wants to merge 9 commits into from
Closed

Remove class name from buttons #465

wants to merge 9 commits into from

Conversation

vanillajonathan
Copy link
Contributor

The class names collide with built-in classes such as the "table" class in Bootstrap.
This results in the buttons inheriting the style from Bootstrap (or other frameworks) that define classes with those names.

https://getbootstrap.com/docs/5.2/content/tables/

The class names collide with built-in classes such as the "table" class in Bootstrap.
This results in the buttons inheriting the style from Bootstrap (or other frameworks) that define classes with those names.
@Ionaru
Copy link
Owner

Ionaru commented May 22, 2022

I agree this can be a problem, but it looks like removing the class name breaks more than you intended.

@vanillajonathan
Copy link
Contributor Author

Removing the class from the button element broke the Cypress end-to-end tests, so I just prefixed the class with the mde- prefix instead.

I would have rather just removed the class from the button element altogether, but this works too and avoids any unintentional styling of the buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants