Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse incorrectly when URL is https://git.test.com.cn/a/b #56

Closed
sinchang opened this issue Feb 26, 2018 · 1 comment · Fixed by #80
Closed

parse incorrectly when URL is https://git.test.com.cn/a/b #56

sinchang opened this issue Feb 26, 2018 · 1 comment · Fixed by #80
Labels
bug

Comments

@sinchang
Copy link
Contributor

result source is com.cn, maybe should test.com.cn.
@IonicaBizau
Copy link
Owner

Thanks for catching this. Contributions are welcome!

sinchang added a commit to AuroraSparkDev/git-url-parse that referenced this issue Mar 14, 2018
@sinchang
Fix issue IonicaBizau#56
219faa5
sinchang added a commit to AuroraSparkDev/git-url-parse that referenced this issue Mar 14, 2018
@sinchang
Fix issue IonicaBizau#56
b33b399
@pvdlg pvdlg mentioned this issue Jul 9, 2018
Closed
pvdlg added a commit to pvdlg/git-url-parse that referenced this issue Jul 9, 2018
@pvdlg
Revert "Fix issue IonicaBizau#56"
e58ee36 
This reverts commit b33b399.
@pvdlg pvdlg mentioned this issue Jul 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parsing of source with 2 parts SLD pvdlg/git-url-parse
2 participants
@IonicaBizau @sinchang