Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .col-gutters for gutters #35

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Conversation

khamer
Copy link
Contributor

@khamer khamer commented Oct 11, 2020

For Issue #32, Added a simple .col-gutters implementation. Added to example as well, and added "unpkg" key to package.json for unpkg.

Copy link
Owner

@IonicaBizau IonicaBizau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I would not modify the core with this change. But this would be welcome in another file. Later we can include specific files to be bundled in the project.

Thank you for this!

@khamer
Copy link
Contributor Author

khamer commented Oct 13, 2020

Hey @IonicaBizau - I moved it into lib/gridly-gutters.css and updated package.json with separate builds. Let me know if there's other stuff you'd like. Happy hacktoberfest.

Copy link
Owner

@IonicaBizau IonicaBizau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! ✨ Thank you so much!

@IonicaBizau IonicaBizau mentioned this pull request Oct 14, 2020
@IonicaBizau IonicaBizau merged commit b86a2b9 into IonicaBizau:gh-pages Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants