Arbitrary compiler options #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonicaBizau
requested changes
Feb 26, 2018
examples/index.js
Outdated
| @@ -14,7 +14,7 @@ Cobol(function () {/* | |||
| DISPLAY "Hello world". | |||
| PROGRAM-DONE. | |||
| STOP RUN. | |||
| */}, function (err, data) { | |||
| */}, {compileargs:{free:true}}, function (err, data) { | |||
There was a problem hiding this comment.
Can you please write this on multiple lines, so it won't be so condensed?
| if (options.free) { | ||
| args.free = options.free; | ||
| } | ||
| Object.assign(args, options.compileargs); |
|
Made the change to make the statement a bit more spacious :) |
|
@IonicaBizau I'm kinda new to adding things to open-source :) please notify me if another pull request or something has to be done. I should have fixed the example so that it's less condensed |
IonicaBizau
approved these changes
Feb 28, 2018
|
@B14m3m3 Sorry, I just missed your last commit. 🙈 Do ping me in such cases. Merging right now. 🚢 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a compiler options object that will be passed to the compiler, to enhance the thing in issue #39.
This should allow the user to specific whatever options there are in the cobc as required. I've added the free flag in the
Hello worldexample to show the intended change.As a small side change i also made was adding a callback to the Fs.unlink as it was giving deprecation errors :). Currently the callback does nothing.