Streams

[IonicaBizau]

I'm trying to add the stream functionality in the toPdf method. The goal is to be able to work with streams instead of files, when it's needed. Rendering in files is still supported.

Currently the toPdf function doesn't work because:

• I don't know how to set custom html that comes not from a file but from a string value.
• I don't know how to pipe the result pdf into a stream, not into a file.

However, the toHtml is working well. If no output field is specified in options, then the callback result will be the html string:

require("http").createServer(function (req, res) {
    myInvoice.toHtml(function (err, data) {
        res.end(data);
    });
}).listen(8000);

This will fix #4. 🔥

[IonicaBizau]

Maybe node-html-pdf by @marcbachmann could help here! I'm gonna give a try. 😄

[stellanhaglund]

Looks promising! :)
Surprised by the fast responses and interest in the submitted issue! :)
Never happened to me before, really appreciate it!

fredag 7 augusti 2015 skrev Ionică Bizău notifications@github.com:

Maybe node-html-pdf https://github.com/marcbachmann/node-html-pdf by
@marcbachmann https://github.com/marcbachmann could help here! I'm
gonna give a try. [image: 😄]

—
Reply to this email directly or view it on GitHub
#5 (comment).

[IonicaBizau]

@idlyapp Hehe, I'm always trying to do my best. I'm really happy when people appreciate the work I've done. Donations are always welcome! Thanks! 🍀

[IonicaBizau]

@idlyapp I pushed a fix for the toPdf function. Please update your code (see the examples in test/index.js) and see what happens. Some tmp files are still created in /tmp dir. Hopefully, Heroku accepts that.

I opened an issue about that here: marcbachmann/node-html-pdf#61

[IonicaBizau]

Something like this:

require("http").createServer(function (req, res) {
    myInvoice.toPdf({ output: res });
}).listen(8000);

[stellanhaglund]

Sounds great will get back to you in a couple of h! Thx!

fredag 7 augusti 2015 skrev Ionică Bizău notifications@github.com:

@idlyapp https://github.com/idlyapp I pushed a fix for the toPdf
function. Please update your code (see the examples in test/index.js) and
see what happens. Some tmp files are still created in /tmp dir.
Hopefully, Heroku accepts that.

I opened an issue about that here: marcbachmann/node-html-pdf#61
marcbachmann/node-html-pdf#61

—
Reply to this email directly or view it on GitHub
#5 (comment).

[stellanhaglund]

Is res the file i should pass to s3?

fredag 7 augusti 2015 skrev Stellan Haglund sh@idly.se:

Sounds great will get back to you in a couple of h! Thx!

fredag 7 augusti 2015 skrev Ionică Bizău <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>:

@idlyapp https://github.com/idlyapp I pushed a fix for the toPdf
function. Please update your code (see the examples in test/index.js)
and see what happens. Some tmp files are still created in /tmp dir.
Hopefully, Heroku accepts that.

I opened an issue about that here: marcbachmann/node-html-pdf#61
marcbachmann/node-html-pdf#61

—
Reply to this email directly or view it on GitHub
#5 (comment).

[stellanhaglund]

No sorry that was http response.

As i understand it the variable i put after output: will be the file?

fredag 7 augusti 2015 skrev Stellan Haglund sh@idly.se:

Is res the file i should pass to s3?

fredag 7 augusti 2015 skrev Stellan Haglund <sh@idly.se
javascript:_e(%7B%7D,'cvml','sh@idly.se');>:

Sounds great will get back to you in a couple of h! Thx!

fredag 7 augusti 2015 skrev Ionică Bizău notifications@github.com:

@idlyapp https://github.com/idlyapp I pushed a fix for the toPdf
function. Please update your code (see the examples in test/index.js)
and see what happens. Some tmp files are still created in /tmp dir.
Hopefully, Heroku accepts that.

I opened an issue about that here: marcbachmann/node-html-pdf#61
marcbachmann/node-html-pdf#61

—
Reply to this email directly or view it on GitHub
#5 (comment).

[IonicaBizau]

No, it's the response stream which comes from the createServer callback.

[stellanhaglund]

Great news! now it's showing in browser! :)

But how would I send the file to for example s3?

[stellanhaglund]

The invoice rows doesn't seem to be rendered though..

[stellanhaglund]

I figured it out,

myInvoice.toPdf({
output: res
}, function (err, data){
console.log(err, data.path);
});

[IonicaBizau]

If you pass a stream to in the output field, then the pdf stream will be piped there. That means you can pass the request stream:

myInvoice.toPdf({ 
    output: Request("http://domain.com/upload-invoice") 
}, function (err, data){
    console.log(err, data.path);
});

It should work I guess... maybe with some changes. 😄

[stellanhaglund]

any idea why task rows isn't rendered?

[IonicaBizau]

@idlyapp Do you have an example (online)?

[stellanhaglund]

I actually did it a little different way, using express, so I simply do a post call to the url and the pdf is rendered and uploaded to where I want it.

This way I can simply put the invoice data as the body of the post, so I don't have a url where you will see the pdf just by loading it.

Is it working for you?

[IonicaBizau]

@idlyapp Thanks for the heads-up! I pushed a fix regarding the description rows.

[stellanhaglund]

Awesome! :)

[IonicaBizau]

🚢 2.0.0 🎉

@stellanhaglund Sorry it took so long to get this fixed, but finally it's happening! 😄