Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of fixes #6

Merged
merged 5 commits into from
Oct 28, 2018
Merged

A couple of fixes #6

merged 5 commits into from
Oct 28, 2018

Conversation

IonicaBizau
Copy link
Owner

  • Validate the url
  • Do not throw if the url is
  • And set normalize to false, by default.
  • The normalize url was failing to work with git+ssh urls

/cc @pvdlg Can you please check this

And set normalize to false, by default.

The normalize url was failing to work with git+ssh urls
@pvdlg
Copy link

pvdlg commented Oct 25, 2018

Thanks a lot for the fast response!

Looks good and works in my use case! However parseUrl('git@github.com:IonicaBizau/git-stats.git', true) still returns wrong values. The normalize parameter doesn't apply for ssh or git URLs so it should probably be ignored and always set to false in those cases. Or maybe setting normalize to true for a git URL would be considered a "user error"?

I think the readme should also be updated as normalize is now false by default. The examples should probably be updated as well.

@IonicaBizau
Copy link
Owner Author

IonicaBizau commented Oct 28, 2018

For now I will merge it like it is (I updated the docs) and bumped the major version. 🚀

But contributions are welcome (maybe normalizing the Git urls?).

@IonicaBizau IonicaBizau mentioned this pull request Oct 28, 2018
@IonicaBizau IonicaBizau merged commit cf4a74f into master Oct 28, 2018
@IonicaBizau IonicaBizau deleted the new-version branch October 28, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants